search

UCSC-MedBook / patient-care

Clincian facing portal showing pathways, signatures, and genes of interest
2 stars 1 forks source link

Sample Group query filter -- it's not appropriately finding forms by sample labels #25

Closed e-t-k closed 8 years ago

e-t-k commented 8 years ago

for: the form_values filter when creating a sample group -- see Meteor Method getFormsMatchingDataSet.

Given a dataset containing a list of samples, it's necessary to determine which forms have records for these samples.

Currently getFormsMatchingDataSet does this by finding all CRFs such that sampleID field contains that sample label as this is the field name in clin.v3.tab file. However this is not the canonical name of the field -- Sample_ID is more canonical but is not guaranteed to be present.

Future implementation of Forms will have a sample_label_field (or similar name) allowing code to determine which field contains sample labels -- change the query filter to use this to correctly find the samples present in a form

Also CRFs will have an associated dataset -- I believe this is already implemented in a branch of Fusion but I can't find which. Change the query filter to use this to find the forms associated with a dataset instead of searching by sample names.

e-t-k commented 8 years ago

getFormsMatchingDataSet has been updated to find by Sample_ID instead of sampleID. Everything in this issue still stands.

e-t-k commented 8 years ago

next branch of querybuilder code now correctly uses sample_label_field in new Forms to find samples wherever they may be.