docs: Data Upload - Githubissues

UCSD-E4E / smartfin-fw3

Smartfin FW v3

GNU General Public License v3.0

1 stars 0 forks source link

docs: Data Upload #90

Open ntlhui opened 1 month ago

ntlhui commented 1 month ago

[ ] src/cellular/dataUpload.hpp:49: error: Member exitState(void) (function) of class DataUpload is not documented.
[ ] src/cellular/dataUpload.hpp:50: error: Member can_upload(void) (function) of class DataUpload is not documented.
[ ] src/cellular/dataUpload.hpp:47: error: Member initSuccess (variable) of class DataUpload is not documented.
[ ] src/cellular/dataUpload.hpp:48: error: Member lastConnectTime (variable) of class DataUpload is not documented.
[ ] :1: error: parameters of member DataUpload::can_upload are not documented
[ ] :1: error: parameters of member DataUpload::exitState are not documented

ed2263e1fbb0b66328a2df6ef0a8531383ddd825

Tylody commented 1 week ago

Seems like DataUpload lastConnectTime (type of system_tick_t) has no uses outside of dataUpload.hpp. Should I remove it?

ntlhui commented 1 week ago

Seems like DataUpload lastConnectTime (type of system_tick_t) has no uses outside of dataUpload.hpp. Should I remove it?

lastConnectTime is likely a remnant or incomplete implementation of rate limiting calls to Particle.connect - previously, we could not do more than 1 call per second to Particle.connect. Leave this in place for now, we need to investigate whether the rate limiting is still a concern.