search

UKPLab / sentence-transformers

State-of-the-Art Text Embeddings
https://www.sbert.net
Apache License 2.0
15.44k stars 2.5k forks source link

add MCC to BinaryClassificationEvaluator #3051

Closed JINO-ROHIT closed 1 week ago

JINO-ROHIT commented 2 weeks ago

This PR links #3027 and adds the Matthews correlation coefficient.

Who can review? @tomaarsen

JINO-ROHIT commented 1 week ago

@tomaarsen gentle ping to have a look

tomaarsen commented 1 week ago

Hello!

I had a quick look and made some small nitpicks, all related to the logs/docstring. Beyond that, it looks solid to me. Well done, thanks for this @JINO-ROHIT, and thanks for the review @reissaavedra

I'll merge this once the tests go green.