UM-ARM-Lab / pytorch_kinematics

Robot kinematics implemented in pytorch
MIT License
443 stars 42 forks source link

Incorrect Documentation for Transform3d Composition Order #46

Open ZHUO130 opened 1 week ago

ZHUO130 commented 1 week ago

The documentation for Transform3d class states that these operations are equivalent: pythonCopyy1 = t3.transform_points(t2.transform_points(t1.transform_points(x))) y2 = t1.compose(t2).compose(t3).transform_points(x) y3 = t1.compose(t2, t3).transform_points(x) However, they produce different results because compose function uses right multiplication instead of left multiplication. This behavior contradicts the documentation. Could you please confirm if this is a bug or if the documentation needs to be updated?