search

UMM-CSci / senior-seminar

Public materials for senior seminar, including assignments, past papers/slides, templates, etc.
https://umm-csci.github.io/senior-seminar/
9 stars 10 forks source link

Show stars on the All Seminars page #51

Closed floogulinc closed 5 months ago

floogulinc commented 1 year ago

Closes #50

chrome_X9b7jtgoWt

emmahsax commented 10 months ago

Sorry to jump in the middle of this. I read the issue #50 that prompted this change. I wonder if we could include something in the message about the fact that not all semesters evaluated papers and presentations for gold stars. I'm not sure exactly what the wording would be, but something like:

As applicable, papers and presentations that were evaluated as deserving a distinction are marked with ⭐.

elenam commented 5 months ago

The PR made a change in a wrong file. Changed it in the layout file. Commits d1ee194bdc1cd6a82ac8e841edc3997db1ea9e64 and a515581e3dadab855a9f371d3a0820db8380a462

floogulinc commented 5 months ago

No it was correct before.

As applicable, papers and presentations that were evaluated as deserving a distinction are marked with ⭐

That should be on the All Seminars page, not the template for individual seminars where "as applicable" isn't needed since the notice is only shown when the seminar had stars.

elenam commented 5 months ago

"As applicable" makes it clear that for some seminars it's not applicable.

On Sun, Mar 31, 2024 at 9:06 PM Paul Friederichsen @.***> wrote:

No it was correct before.

As applicable, papers and presentations that were evaluated as deserving a distinction are marked with ⭐

That should be on the All Seminars page, not the page for individual seminars where "as applicable" isn't needed since the notice is only shown when the seminar had stars.

— Reply to this email directly, view it on GitHub https://github.com/UMM-CSci/senior-seminar/pull/51#issuecomment-2029032481, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAERJYPXDBTBJEW6KYUDJ4LY3C6I7AVCNFSM6AAAAAA3ZXEBBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGAZTENBYGE . You are receiving this because you modified the open/close state.Message ID: @.***>

-- Dr. Elena Machkasova Associate Professor of Computer Science Division of Science and Mathematics University of Minnesota, Morris Office: Sci 2325 (320) 589-6308 http://cda.morris.umn.edu/~elenam/ Pronouns: she/her/hers or any other

elenam commented 5 months ago

I can add it back to "All Seminars", but the language needs to be consistent between individual pages and the "All seminars".