search

UNCG-DAISY / Instagrain

A camera for measuring sediment grain sizes with edge ML
MIT License
20 stars 2 forks source link

PDF of grain size #90

Closed ebgoldstein closed 2 years ago

ebgoldstein commented 2 years ago

it might be helpful to display a PDF of the grain size, and not just the CDF. (this suggestion is from @ncohn).

I am not sure how to display it graphically (if they should be on the same plot panel? or with a button? or two panels?)

here is a code snippet for the needed steps w/ scipy.misc.derivative:

https://datascience.oneoffcoder.com/pdf-cdf.html

jacobstasiewicz commented 2 years ago

evan I think it would be easiest to make the entire plot a button, so when clicked it will switch between the two types

ebgoldstein commented 2 years ago

Good idea

ebgoldstein commented 2 years ago

@jacobstasiewicz - give this a test on the device. There was no plot showing when i tried it this morning on my device

jacobstasiewicz commented 2 years ago

give it a try now

ebgoldstein commented 2 years ago

works - super nice!.. the code also seems faster to me!

jacobstasiewicz commented 2 years ago

Thanks! Is there a way to quantify the speed of the code? I would like to run a test and make a base line so when we are streamlining the code I can see what methods work best, just out of curiosity

ebgoldstein commented 2 years ago

i made a new issue for that..