search

UNOMP / node-multi-hashing

9 stars 44 forks source link

Use Nan2 API to be compatible with all node versions #5

Closed Kukunin closed 7 years ago

Kukunin commented 8 years ago

Sorry, I accidentaly removed my branch, and previous PR was automatically closed

Kukunin commented 8 years ago

I tested neoscrypt algorythm on fullstack of UNOMP (mining-pool, stratum + multi-hashing). It compiles on all versions of Node, but works only on 0.10. It crashes on 0.12, 4.4.2, 5.10.0.

It seems, scrypt works on any version

I hope, someone will participate with this issue as well.

bonesoul commented 7 years ago

@Kukunin is your NAN branch working already with node 8? https://github.com/Kukunin/node-multi-hashing/tree/nan

Kukunin commented 7 years ago

@bonesoul I haven't tried with Node 8 but it works perfectly with Node 7. Take a look my master branch here: https://github.com/Kukunin/node-multi-hashing. I had to disable -Ofast to avoid segmentation faults.

bonesoul commented 7 years ago

@Kukunin thanks, v7 and v8 shouldn't be so different i guess. ill give it a try