UQComputingSociety / uqcsbot-slack

:mortar_board: UQCSbot: our friendly little Slack bot
https://slack.uqcs.org.au
MIT License
55 stars 44 forks source link

Implement !advent command (again) #558

Closed katrinafyi closed 3 years ago

katrinafyi commented 3 years ago

Builds off of #397 (see there for background and discussion). Here's a comparison between #397 and this branch.

To do:

Screenshots: image image

katrinafyi commented 3 years ago

More recent screenshots: image

nicklambourne commented 3 years ago

jenkins retest this please

nicklambourne commented 3 years ago

@kentonlam I'm in the process of upgrading the bot to 3.9 so we can have literals and fix the typing errors.

katrinafyi commented 3 years ago

I've pushed some commits which sidestep the typing problem (it should've been an enum anyway) and fixed formatting issues.

Thanks for updating Python. Working on this PR made me realise how many quality of life features are missing from 3.6 (no dataclasses 😢).

nicklambourne commented 3 years ago

lol, I'd fixed most of those myself along the way, there goes that night's work 😂

katrinafyi commented 3 years ago

Oops, I didn't know you were working on it as well 😅