Update MP JSON elements

US-EPA-CAMD / easey-ui

Project Management repo for EPA Clean Air Markets Division (CAMD) Business Suite of applications

MIT License

0 stars 0 forks source link

Update MP JSON elements #6317

Open annalbrecht opened 3 months ago

annalbrecht commented 3 months ago

Change the name of the following to match what is shown in the "ECMPS 1.0/ Beta Reporting Instructions" column: <html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">

MP JSON Schema | ECMPS 1.0/ Beta Reporting Instructions -- | -- potentialAnnualMassEmissions | potentialAnnualHgMassEmissions

Acceptance tests:

Review of the JSON schema file shows the updated JSON elements
A file using the new JSON element names is able to be imported successfully
Upon export, the exported file shows the elements with the updated names

bryanramirez1 commented 3 months ago

Pausing this ticket until the EPA determines how to address the reporting instructions.

mxtomoto1 commented 2 months ago

Acceptance tests:

Review of the JSON schema file shows the updated JSON elements
A file using the new JSON element names is able to be imported successfully ORIS 963 location 33's MP was able to be exported and reimported and evaluated without issue. Additionally, a new LEE Qualification was created for 55856 location 01. This was also evaluated and exported / reimported without issue.
Upon export, the exported file shows the elements with the updated names

ibarra-michelle commented 2 months ago

Verified in test with Config ORIS 963 Loc 33:

In the "Resources > Reporting Instructions" web area, the MP json file includes the correct JSON text.
The exported file includes the correct json text.
The MP module successfully imports and evaluates the file with the correct json text.

@yonatan-dp , could you update the json file's "lastUpdated" fieldso our users are aware the file has been updated? This issue will be address in ticket #6198 .

yonatan-dp commented 2 months ago

@ibarra-michelle, adding this for reference since we just discussed it on the standup. The decision is to update the "lastUpdated" field on the next ticket that modifies the JSON elements.