US-GHG-Center / veda-config-ghg

Veda config for GHG
https://ghg-demo.netlify.app
Other
3 stars 15 forks source link

Remove subtitle in homepage hero and about page #657

Closed j08lue closed 2 weeks ago

j08lue commented 2 weeks ago
netlify[bot] commented 2 weeks ago

Deploy Preview for ghg-demo ready!

Name Link
Latest commit 5aab6dab1c957bc44f7a945f7d082f8d8c26bc26
Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/67353354050ee60008d12bb3
Deploy Preview https://deploy-preview-657--ghg-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

j08lue commented 2 weeks ago

@Jeanne-le-Roux, on the about page, should there be another subtile? Or none?

image

Jeanne-le-Roux commented 2 weeks ago

@j08lue no subtitle for that page.

I think that's the only other place the tagline shows up - but need to double check. (edit - I see you already did that!)

j08lue commented 2 weeks ago

image

🙄

VEDA UI does this

description={
  aboutContent?.data.description || 'This is the default description'
}

https://github.com/NASA-IMPACT/veda-ui/blob/6e929e8a9d075776a206bfd020c58107e71435ea/app/scripts/components/about/index.tsx#L19

j08lue commented 2 weeks ago

Gone.

image

j08lue commented 2 weeks ago

Is this acceptable, @Jeanne-le-Roux? Or should we ask for a quick design review to adjust the whitespace now that there is no subtitle? That might require overriding the about page header, though. 🙄

Jeanne-le-Roux commented 2 weeks ago

@j08lue I think it looks fine in the preview link as is!

j08lue commented 2 weeks ago

Great! You want this change to be in the next release, right? If so, please merge this PR, @Jeanne-le-Roux, so it gets into staging.

Jeanne-le-Roux commented 2 weeks ago

@j08lue thanks for jumping in and taking care of this!