search

USCC-LAB / Weekly

Save your life. Make weekly work automatic.
http://weekly.readthedocs.io/en/feature-docs/
Apache License 2.0
5 stars 6 forks source link

Follow PEP8 code style, Re-organize files structure and make template class of protocol #8

Closed amikai closed 7 years ago

amikai commented 7 years ago

[MAIL] Re-organize files structure [MAIL] Make mail.py and protocol/smtp.py follow to PEP8. [MAIL] impl abstract class of protocol (Prot class).

iankuan commented 7 years ago

@as23041248 Thanks for your contribution. There're

  1. It seems not to be pluggable anymore right?

tests/mail_testsuite/dummy_mail/smtp/dummy.py#L8

Mail = mail.mail(smtp.smtp)

However, I would like to accept this ff67087 at dev/oop branch branch under observance.

  1. This rearrangements in e05d204 would be fine, but I can't distinguish whether better or not. Maybe you should post an Issue first. Moreover, I agree that it is too complex at all.

  2. You should separate this PR into three pieces. That's quite a composite improvement. Notice that one PR should achieve one improvement.

  3. Last but not the end, following [PEP 8 -- Style Guide for Python Code(https://www.python.org/dev/peps/pep-0008/) would be great. Thanks for your contribution. Please PR to dev branch.

  4. The important one is you should PR into dev branch or other development branches. I don't accept any PR to master branch.