USDA-ARS-NWRC / awsm

Automated Water Supply Model (AWSM) was developed at the USDA Agricultural Research Service. AWSM was designed to streamline the workflow used to forecast the water supply of multiple water basins.
Other
9 stars 2 forks source link

68 smrf integration #81

Closed scotthavens closed 4 years ago

scotthavens commented 4 years ago

Focusing on a better integration of SMRF and Pysnobal to reduce code duplication. The old AWSM version had many things as just functions passing around an AWSM instance. This moves to a class based approach to house all the same functionality with expanded testing.

This requires the SMRF PR #188 that adds better API functionality to SMRF.

Note: this overhaul is still a work in progress and some scripts like run_awsm_daily are broken.

scotthavens commented 4 years ago

ipysnobal.py is still a bit of a mess and could use still be DRY'd out. Not full sure what else can be smoother but perhaps consolidate how Pysnobal is ran instead of it being broken up into a few methods.