Pep8 cleanup and address deprecation warnings - Githubissues

USDA-ARS-NWRC / weather_forecast_retrieval

Weather forecast retrieval gathers relavant gridded weather forecasts to ingest into physically based models for water supply forecasts

Other

6 stars 1 forks source link

Pep8 cleanup and address deprecation warnings #14

Closed jomey closed 4 years ago

jomey commented 4 years ago

This looks like a lot of changes and they pretty much repeat throughout the files:

Organize imports to have standard libraries first, then third-party, and then internal (https://code.google.com/archive/p/soc/wikis/PythonStyleGuide.wiki)
Change comparison with None to is instead of ==
Add numpy as dependency, which address deprecation warning of pandas to not reference pd.np
Replaced xarray drop with drop_var
Update some outdated doc strings
Use spaces instead of tabs

All tests pass.