search

USDepartmentofLabor / Ilab-do-good

ILab Do Good
0 stars 3 forks source link

Functional - iOS - French - Not All Text on Search Results Page is French #115

Closed jfc3-dol closed 6 years ago

jfc3-dol commented 6 years ago

While testing that VoiceOver was reading the correct languages, I tested the search function. Looking at the screen while listening to the French I noticed that the word "Search Results" and "X results found for XYZ" where in English instead of French.

See screenshot below of what I'm referring too.

cc - french - search results

ghost commented 6 years ago

Fixed in the commit made at 7.15pm on 8/7/18

jfc3-dol commented 6 years ago

Because I couldn't get my iOS devices updated yet, I looked at them on the website, and the word has been translated into French.

Will close once I see them updated on the iOS devices.

jfc3-dol commented 6 years ago

For some reason after @giridhar rebuilt the iOS for me only it still is showing the English words as in the image above.

ghost commented 6 years ago

fixed in the latest push on 8/18

jfc3-dol commented 6 years ago

All the text on the search results screen is in French as expected.

Closing issue.