cristinamullin
commented
1 month ago When making decisions to use/reject sites and their associated results and/or to combine sites, users may want to consider multiple site flags at once (users want to know if a site lat/long is imprecise when making a decision to group or not group the site with a flagged nearby site) instead of reviewing them independently.
As part of this issue, consider addressing this by using different colors/symbols on the map to flag sites for different issues (imprecise coordinates vs. outside of the US vs. potentially duplicated nearby sites). In addition, what happens if a site(s) are flagged for multiple reasons? The colors/symbols should be unique for that situation as well - so that a user can tell if a site(s) are both potentially duplicated nearby sites & also have imprecise coordinates.
Is your feature request related to a problem? Please describe.
Users have requested to be able to review flagged sites on a map before making a decision to keep/remove them.
Suggest to develop a new site review map function in the R package to display all sites and flag nearby sites, sites outside of the US and imprecise coordinates for easy user review. This new map function can also be used in the new "Flag Sites" tab in the shiny app (see related Shiny issue & mock ups here: https://github.com/USEPA/TADAShiny/issues/136).
We already have two functions in the R package to assist with monitoring location QAQC. TADA_FindNearbySites() flags nearby sites that may be the same site (same area monitored by multiple orgs or the same org submitted data for the same area multiple times with different monitoring location ID's). TADA_FlagCoordinates() flags sites with imprecise coordinates and coordinates outside of the US.
The user interactivity/workflow in the shiny app should also be replicated as best as possible in the TADA Module 1 vignette. See related issue: https://github.com/USEPA/TADAShiny/issues/149
Fields to consider including in the Nearby Site review pop up (can they be grouped in this way & is this too many/is there a max?):
Describe the solution you'd like
Develop new site review map function for this purpose and add the new map function to the Module 1 vignette.
Reminders for TADA contributors addressing this issue
New features should include all of the following work:
[ ] Create the function/code.
[ ] Document all code using comments to describe what is does.
[ ] Create tests in tests folder.
[ ] Create help file using roxygen2 above code.
[ ] Create working examples in help file (via roxygen2).
[ ] Add to appropriate vignette (or create new one).