USEPA / useeior

Estimating potential environmental impacts of goods and services in the US economy
MIT License
33 stars 21 forks source link

Improve or drop barplotFloworImpactFractionbyRegion() #310

Open WesIngwersen opened 3 months ago

WesIngwersen commented 3 months ago

https://github.com/USEPA/useeior/blob/636a81b3f6a806a6c3b1d50f62c0cc4de977b9fe/R/VisualizationFunctions.R#L306

Not easy at all to use - takes a R1_calc_result A matrix from model result which is for one region supposedly but this is very unclear in how to derive this because its not defined anyway

WesIngwersen commented 3 months ago

well there is an example on its use here but its not clear how well it would work for models with multiple regions

https://github.com/USEPA/useeior/blob/6d5209aa756f793ef850500bb39009b2c952cdb2/inst/doc/Example.Rmd#L71-L74