UUDigitalHumanitieslab / gretel

GrETEL4 (fork from CCL-KULeuven)
http://gretel.hum.uu.nl
Other
4 stars 2 forks source link

Refactor results step to smaller components #277

Closed bbonf closed 2 years ago

bbonf commented 2 years ago

For the MWE route I would like to have a slightly modified results page (as seen in https://github.com/UUDigitalHumanitieslab/gretel-django/tree/django/mwe-backend)

I'm making a separate PR here to remove some work from a future massive MWE PR

oktaal commented 2 years ago

I've re-enabled AOT in https://github.com/UUDigitalHumanitieslab/gretel/commit/3091520a4157f896780e3af0ec839adbec84ee99 and modified the typing to allow compilation.

bbonf commented 2 years ago

Resolved conflict with feature/matrix-model, so this can be merge after #278

oktaal commented 2 years ago

Did a fairly rough move of the missing functions to make the build succeed again. It could be restructured more elegantly, and I've seen at least one bug with the filters not showing as expected.