search

UWMadisonUcomm / uw-ui-toolkit

A web front-end toolkit based on Bootstrap for designing and developing modern, mobile-first websites for the University of Wisconsin-Madison
Apache License 2.0
16 stars 15 forks source link

bumb bootstrap version to 3.2.0 #53

Closed nacengineer closed 10 years ago

nacengineer commented 10 years ago

To the best of my knowledge there aren't any API breaking changes in 3.2.0

jnweaver commented 10 years ago

Thanks David! Good idea. I just scanned over the 3.2 changes and I don't see anything too major in the change set. That said, I think we'll re-version ourselves to 1.2.0, since this was a minor upgrade (major.minor.maintanence in SemVer terms and since Bootstrap is fundamental to the Toolkit.

Also, I noticed another commit come in to this Pull Request just a bit ago, adding top and bottom padding to .uw-content-classic .container .main. I'm not sure if you intended that to be tacked on to this PR or not. With PRs (this is all fairly new to me as) you typically will want to fork the main project and then create a "feature" branch of that for your PR instead of working within your fork's master branch. Then you can submit that feature branch as the PR. If you end up making changes intended to update your PR, just make new commits to your feature branch and they'll get added on (as was the case above). If you want to make other changes not intended for the PR, just create another feature branch so those commits stay out of the PR.

Also, I think in general, you can leave the version numbers for the main project untouched when submitting a PR. After the maintainer of the project accepts your PR, they can then release a new version (bumping the version number at the same time) or sit on the accepted PR and release it later with other accepted PRs and commits.

Does this make sense? Like I said, I'm pretty new to being on this end of PRs so I may not have it right, myself.

If that makes sense though, go ahead and create a branch of your fork and commit only the Bootstrap version bump to it and then resubmit as a PR.

Thanks!

nacengineer commented 10 years ago

ok. so you're not using tiny on Semantic Versioning? no problemo

I thought I had pushed the second file to a fork so I must have mistakenly added it. I will resubmit the PR. You can close this one

jnweaver commented 10 years ago

Thanks!