search

UWMadisonUcomm / uw-ui-toolkit

A web front-end toolkit based on Bootstrap for designing and developing modern, mobile-first websites for the University of Wisconsin-Madison
Apache License 2.0
16 stars 15 forks source link

Remove myuw frame, 15px padding, update bower #59

Closed jhanstra closed 9 years ago

jhanstra commented 9 years ago

3 things in this pull request:

1) Removing unnecessary MyUW frame styles. The toolkit should only style portlet content. 2) Change 25px column gutter padding to 15px. This is what Bootstrap uses and I don't think we should change it for UW. This was skewing MyUW's styles when I pulled in the Toolkit. 3) Release a new Toolkit, with MyUW portlet styles.

jnweaver commented 9 years ago

Looks good, Jared. I'm cool with resetting the gutter to the Bootstrap default (I think: need to look at first still), but I want to think about the version number and documenting this change since it's pretty fundamental to designs already implemented using the 25px gutter. I'm not sure how many people are managing the Toolkit using Bower or NPM, etc. (maybe just us in UMarketing) but I think we should bump this to 0.2.0 and I'll note it under the releases and add a changes doc to the project. I'm in a meeting right now but will try to get to this after or first thing tomorrow am after another meeting.

jhanstra commented 9 years ago

Sounds great. I'm fine with bumping up to 0.2.0.