search

UbiquityRobotics / ubiquity_main

Main documentation as well as other misc files
Other
19 stars 7 forks source link

Write a camera contrast and brightness auto calibrate based on fiducial feedback #253

Open MoffKalast opened 2 years ago

MoffKalast commented 2 years ago

Added by @davecrawley

MoffKalast commented 2 years ago

Converted this into an issue to ask why is this something that we'd need. Isn't it kind of useless with adaptive thresholding that both aruco and stag surely use?

davecrawley commented 2 years ago

Sure if 1) Arucco and STaG both have good adaptive thresholding 2) The dynamic range of the camera is wide enough to ensure that the contrast ratio of the markers is always in the range where adaptive thresholding works regardless of gain and contrast settings 3) The noise characteristics aren't related to gain and contrast settings and are basically irrelevant

For sure 2 is not true - as Arrucco fails if the gain and contrast ratio of the camera is set wrong - I've seen it and its caused issues for customers. 3 is almost certainly not true 1 I have no idea if their adaptive thresholding can be described as "good" or what it does at all.

So yes - I still think this is a relevant project.

David

=================================================== Ubiquity Robotics, Inc. is honored to win the Silicon Valley Robotics good robot industry award in the commercialization category. Ubiquity Robotics wins SVR good robot industry award https://svrobo.org/ubiquity-robotics-wins-commercialization-award-in-svr-good-robot-industry-awards/

On Mon, Oct 25, 2021 at 10:05 PM MoffKalast @.***> wrote:

Converted this into an issue to ask why is this something that we'd need. Isn't it kind of useless with adaptive thresholding that both aruco and stag surely use?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/UbiquityRobotics/ubiquity_main/issues/253#issuecomment-951265510, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYN4VUNOKA6GXSA7MMI3ULUIW2ARANCNFSM5GWDCRYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

MoffKalast commented 2 years ago

Ok good, makes sense.