search

UmbHost / Our.Umbraco.Forms.uCaptcha

MIT License
5 stars 0 forks source link

Umbraco 13 System.TypeLoadException #10

Closed slag-dev closed 8 months ago

slag-dev commented 8 months ago

uCaptcha 5.0.0 / Umbraco 13.2.2 / Umbraco Forms: 13.1.1 / Umbraco Cloud

When attempting to deploy new update on Umbraco Cloud we get following errors: System.TypeLoadException: Could not load type 'Umbraco.Forms.Core.Attributes.Setting' from assembly 'Umbraco.Forms.Core, Version=13.0.2.0, Culture=neutral, PublicKeyToken=null'.

if we remove your package Umbraco Forms works as expected.

AaronSadlerUK commented 8 months ago

Hi @slag-dev

I will investigate

AaronSadlerUK commented 8 months ago

@slag-dev I have taken a look and I can get this running on those versions...

Could you check to see if you have Umbraco.Forms.Core 13.0.2.0 referenced anywhere? Maybe you need to explicitly install version 13.1.1?

slag-dev commented 8 months ago

Hi @AaronSadlerUK

No we don't have any dependencies for Umbraco.Core 13.0.2.0 only 13.1.1... on the local environment it works but if we deploy it to the umbraco cloud the error occurs...

AaronSadlerUK commented 8 months ago

Hi @slag-dev

Ok, we don't have a way of testing with Umbraco Cloud (due to our hosting products) We have it working on our site, in local development and other non Umbraco Cloud V13 sites.

Could you reach out to Umbraco Cloud support

slag-dev commented 8 months ago

Hi @AaronSadlerUK

Thanks for your feedback. Yes we contacted them but they said it's a third party package...

AaronSadlerUK commented 8 months ago

I would need access to a Umbraco Cloud project to be able to investigate

slag-dev commented 8 months ago

that could be a bit tricky :)

AaronSadlerUK commented 7 months ago

@slag-dev I managed to trigger this error on one of my upgrades, I was able to fix it by upgrading another package which was not updated to support V13.

In this case it was my Our.Umbraco.Forms.Intl_Tel_Input input package, so my advice would be to check all of your Umbraco Forms packages support Umbraco 13

slag-dev commented 7 months ago

@AaronSadlerUK thanks for your feedback - from my point of view all dependencies should be up to date and support umbraco v13. we don't have any other umbraco forms addons.

AaronSadlerUK commented 7 months ago

@slag-dev Ok, there must be some other issue, we have upgraded our website to 13.2.2 (https://umbhost.net) and the plugin works correctly, we also spoke with another developer using V13 over the weekend and it works correctly for them.

The package does not have any dependencies on other Umbraco packages, I was explaining that the fix for ours was to update another unrelated package.

If you wish to investigate and submit a PR the source code is available, otherwise we can investigate if you can provide access to the source code at our usually hourly rate.

slag-dev commented 7 months ago

perfect thanks for your offer - we will check everything again