UmbraSpaceIndustries / USI_Core

USI Parts Pack
Other
18 stars 26 forks source link

Add LqdOxygen to all liquid storage tanks #134

Closed panarchist closed 2 years ago

panarchist commented 3 years ago

This PR does the following:

Known issues: LqdHydrogen displays as "LH2" in the tank selector, but LqdOxygen displays by name - this is due to FStextureSwitch2 using the CRP localization files and pulling #LOC_CRP_LqdHydrogen_Abbreviation for LH2 and #LOC_CRP_LqdOxygen_DisplayName for LO2 (LOX). The resources are curated by different maintainers, so resolving it would require the RealFuels maintainer to add an entry for #LOC_CRP_LqdOxygen_Abbreviation with a value of "LO2" or "LOX" to be consistent with NFT's "LH2" abbreviation. If it is switched to "LOX", the Tank10.dds file would need to be edited accordingly.

tjdeckard commented 2 years ago

Hello and thanks for the pull request! I've setup a temporary feature branch to merge your PR into because we're in the process of rearranging branches. The branch called "master" will be going away soon, being replaced by the branch called "main".