Subscriptions still not shown (help needed from Basic or Premium subscriber!)

cnpgs commented 4 years ago

Describe the bug Just installed this integration, and noticed that the Humble Trove and Humble Choice subscriptions are not shown, similar to bug #136 Also saw another user with the same issue here: https://github.com/UncleGoogle/galaxy-integration-humblebundle/pull/137

Expected behavior Humble Trove and Choice suscriptions should be shown and synced

Plugin installed Directly from Galaxy

Provide logs Log archive attached plugin-humble-f0ca3d80-a432-4d35-a9e3-60f27161ac3a.zip

GOG_Humble_bug

Currently a Humble Choice subscriber

Version number is 0.9.1: GOG_Humble_bug2

How you can help if you're Basic or Premium or Lite subscriber:

_(EDIT by UncleGoogle)

Go to:

humblebundle.com/api/v1/subscriptions/humble_monthly/subscription_products_with_gamekeys
search for "contentChoiceData"
write here what is the next word after contentChoiceData (expected is initial-premium or initial-basic initial-lite, but I need confirmation)

UncleGoogle commented 4 years ago

Hi @cnpgs, Do you have classic humble bundle plan? https://support.humblebundle.com/hc/en-us/articles/360036658733-Humble-Choice-Classic-Plan-FAQ

cnpgs commented 4 years ago

Hi @cnpgs, Do you have classic humble bundle plan? https://support.humblebundle.com/hc/en-us/articles/360036658733-Humble-Choice-Classic-Plan-FAQ

Yep, that's the one I have

UncleGoogle commented 4 years ago

Ok, thanks for confirmation.

My Idea is that humble may want to distinguish product offers in the future depending on subscription type. So since August 2020, instaed of "initial" license there are:

initial-without-order - for not unlock month yet initial-classic initial-basic (?) initial-premium (?) initial-lite (?) (?) - I need someone with appropriate subscription to confirm that. Basically go to https://humblebundle.com/api/v1/subscriptions/humble_monthly/subscription_products_with_gamekeys (when you're logged in to humble) and check what is under "contentChoiceData". \ lite theoretically has 0 choices but who knows - maybe there will be special offers in the future...

I need at least one (?) to be confirmed to apply my changes. Before that there is fix for "classic" plan in PR linked above. Just close Galaxy and then unpack this with overriding files: src.zip in C:\Users\your-user-name\AppData\Local\GOG.com\Galaxy\plugins\installed\humble-....

cnpgs commented 4 years ago

Ok, thanks for confirmation.

My Idea is that humble may want to distinguish product offers in the future depending on subscription type. So since August 2020, instaed of "initial" license there are:

initial-without-order - for not unlock month yet initial-classic initial-basic (?) initial-premium (?) initial-lite (?)* (?) - I need someone with appropriate subscription to confirm that. Basically go to https://humblebundle.com/api/v1/subscriptions/humble_monthly/subscription_products_with_gamekeys (when you're logged in to humble) and check what is under "contentChoiceData".

lite theoretically has 0 choices but who knows - maybe there will be special offers in the future...

I need at least one (?) to be confirmed to apply my changes. Before that there is fix for "classic" plan in PR linked above. Just close Galaxy and then unpack this with overriding files: src.zip in C:\Users\your-user-name\AppData\Local\GOG.com\Galaxy\plugins\installed\humble-....

Thanks for the info and for the quick fix; I can confirm that the subscriptions are now shown!

However, I can't see the December 2019 Humble Choice as a separate subscription (along with previous 'Monthly' subscriptions, although I'm not sure if these are supposed to be supported), even though I do have it...in fact, games claimed are shown, but under the 'Not in Subscriptions' group.

As regards the "contentChoiceData", I can confirm I have two: one with "initial-classic", and another with "initial".

UncleGoogle commented 4 years ago

I'm glad to hear.

I also can't see the December 2019 Humble Choice as a separate subscription

this is supposed to be visible, can you drop your logs to me? Copy those after ~2 min after Galaxy is restarted.

You can also go though https://humblebundle.com/api/v1/subscriptions/humble_monthly/subscription_products_with_gamekeys pasting "cursor" as last part of the next url for example: https://www.humblebundle.com/api/v1/subscriptions/humble_monthly/subscription_products_with_gamekeys/CnoKEgoFc3RhcnQSCQiAyNSkx7HqAhJgahFzfmhyLWh1bWJsZWJ1bmRsZXJLCxIMTW9kZWxQb2ludGVyIiVQcm9kdWN0LW1hY2hpbmVfbmFtZS1qdWx5XzIwMjBfY2hvaWNlDAsSB1Byb2R1Y3QYgIDEm_2snwkMGAAgAQ==

after a few iterations you should see December 2019 Humble Choice, then also products from Humble Monthly

(along with previous 'Monthly' subscriptions, although I'm not sure if these are supposed to be supported)

this is not supported (yet). Do you see value in showing those games under subscription tab? I'm considering copying all monthly games from owned to subscriptions just for the user information but all under one big "Humble Monthly". What do you think, good idea?

As regards the "contentChoiceData", I have two: one with "initial-classic", and another with "initial".

ou, really? I can see only 'initial-classic'. Can you poste that json here? There is no sensitive data I think (gamekey is like order id bounded to your account so anybody cannot use it)

cnpgs commented 4 years ago

If you don't mind, I will be sending you an email with the requested files (log file, and 3 subscription_product_with_gamekeys files)...whilst I also do not believe that there is any sensitive data that could be exploited, I'd still sleep better if this data isn't publicly available to everyone :)

(along with previous 'Monthly' subscriptions, although I'm not sure if these are supposed to be supported)

this is not supported (yet). Do you see value in showing those games under subscription tab? I'm considering copying all monthly games from owned to subscriptions just for the user information but all under one big "Humble Monthly". What do you think, good idea?

Sounds like a good idea, particularly to separate the Monthly subscriptions from individual games bought in the store; what also might be useful would be to further group the 'Humble Monthly' subscriptions into individual months (like what is being done with Humble Choice, seeing that Humble Choice subscriptions are practically just renamed versions of Humble Monthly (well, apart from the changes in the number of choices you can make...), so it would be nice to have a sort of continuation given that Choice and Monthly are similar to each other), and would give the user an idea of when these games were acquired (as is the case for the Humble Choice subscriptions).

brunotojo commented 4 years ago

I am a first month Premium subscriber (with coupon) . Attachment follows.

download.txt

UncleGoogle commented 4 years ago

Hi @Neomixer, thanks for log. For now it looks like your August subscription is not unlocked yet. Could you please paste again after you claim some games?

UncleGoogle commented 4 years ago

@Neomixer I need one more information from you. Please go to https://www.humblebundle.com/subscription/august-2020 click Unlock (if not unlocked yet), make at least 1 choice and paste again the response from humblebundle.com/api/v1/subscriptions/humble_monthly/subscription_products_with_gamekeys

brunotojo commented 4 years ago

@UncleGoogle Sorry, I wasn't notified the first time. I noticed the same anomaly, but September is my first month. While I have unlocked all games from September, I can't unlock anything from August, sorry I couldn't be more helpful.

UncleGoogle commented 4 years ago

@Neomixer Ah, I see... that is reasonable. The API we inspect is apparently used to show only previous months regardless of ownership.

September data can be find when you open https://www.humblebundle.com/subscription/september-2020 To find it:

open devtools (ctrl+shift+i)
switch to tab Source
press Esc to show console
go to Search, type webpack-monthly-product-data
go to found line
copy the whole line under found webpack-monthly-product-data html tag

hbinspect

then paste here.

brunotojo commented 4 years ago

There is no tag like that. The "september-2020" file is completely blank.

UncleGoogle commented 4 years ago

🤔 really strange. And if you refresh the page? It once had happen to me that there is no webpack data until refresh...

brunotojo commented 4 years ago

Sorry for the late response, I've seen your question but forgot to answer it. I've tried refreshing and opening in an incognito tab to no avail.

cnpgs commented 4 years ago

@Neomixer , are you sure you're viewing the correct item? In your previous screenshot, you are showing the contents of some file called 'd9511e5ece...b9e.js', and not the 'september-2020' page (from your screenshot, its tab is right next to the 'd9511e5ece...b9e.js' one, but is not selected [as evidenced by the blue underline on the .js tab]). Ensure you click on 'september-2020' so that you are viewing its contents; you will also probably need to refresh the Humble webpage if you open the dev tools right after loading the webpage.

brunotojo commented 4 years ago

@cnpgs As I said, 'september-2020' page is blank. I tried multiple times under different circumstances, it is always blank for me.

UncleGoogle commented 3 years ago

@Neomixer or anyone with Basic or Premium subscription plan, can you paste your response from humblebundle.com/api/v1/subscriptions/humble_monthly/subscription_products_with_gamekeys now? It should contain information about september.

nullnetworks commented 3 years ago

I'm having the same issue as a classic subscriber. None of the subscription options show up in settings->features->humble bundle

lucasgeremias6 commented 3 years ago

I'm having the same issue, no Trove or Choice games show up in the Subscriptions bookmark. The fix linked above didn't change much, am I doing something wrong?

UncleGoogle commented 3 years ago

@lucasgeremias6 which fix? I don't remember I've put a fix here. Try this: https://github.com/UncleGoogle/galaxy-integration-humblebundle/pull/140#issuecomment-730548398 Are you premium or basic subscriber?

EDIT. Ah, the src zip from the second post in this thread. Anyway - try a new build and please share your logs. Also - please follow the instruction here: https://github.com/UncleGoogle/galaxy-integration-humblebundle/issues/139#issuecomment-708360710

lucasgeremias6 commented 3 years ago

I did just that. Now I only get the "plugin has crashed" error message. The log is totally empty.

I'm a Classic sub.

UncleGoogle commented 3 years ago

@lucasgeremias6 are you on windows or mac?

lucasgeremias6 commented 3 years ago

Win 10 machine, up to date as well.

If it helps, I ran into the same issue (plugin has crashed) anytime I tried to install by extracting plugins/installed it crashed as well. It doesn't crash when installing through Galaxy though.

UncleGoogle commented 3 years ago

I don't know why it is crashing for you. You can paste your installed folder content here - maybe something is wrong with your installation method.

Another option to debug - open cmd and run this command C:\Program Files (x86)\GOG Galaxy\python\python.exe C:\Users\<yourusername>\AppData\Local\GOG.com\Galaxy\plugins\installed\build\plugin.py 123 456 and paste what you see

lucasgeremias6 commented 3 years ago

humble.zip

That's the plugin folder after I installed it and tried to run it once. I installed by extracting the folder "build" to plugins/installed and running Galaxy, when I start it to connect my account.

UncleGoogle commented 3 years ago

hmm. That is not exactly what I've posted - it is 8MB (23MB unpacked), mine is 2,5MB https://github.com/UncleGoogle/galaxy-integration-humblebundle/pull/140#issuecomment-730548398. You have added venv directory. You don't have to install anything, all dependencies are shipped with the plugin.

Make sure you remove all humble plugins from installed dir. The one that is crashing may be loaded firstly. Anyway, I think I'm going to release what I have so far.

UncleGoogle commented 3 years ago

@nullnetworks @cnpgs @lucasgeremias6 @Neomixer I've created a new prerelease here: https://github.com/UncleGoogle/galaxy-integration-humblebundle/releases/tag/v0.9.2a

Please try it out if it works for you.

lucasgeremias6 commented 3 years ago

It's still crashing for me when I install from git, but I believe that's something to do with my setup and not with the plugin itself, so take my feedback with a grain of salt, please. Crashing happens on both of my computers.

UncleGoogle commented 3 years ago

Did you follow install instruction from Readme? https://github.com/UncleGoogle/galaxy-integration-humblebundle#installation (latest release or from source)

lucasgeremias6 commented 3 years ago

yes, I did. It still crashes, it doesn't crash when I install it through Galaxy itself.

nodeunit commented 3 years ago

Hello, I am also facing this issue (missing options under Features, no Trove or Choice games) as a Classic subscriber with the latest install of 0.9.2a

Oxenoth commented 3 years ago

@UncleGoogle - I tested your fix in 0.9.2a pre-release. There is one small typo in plugin.py function _normalize_subscription_name - you have octover instead of october. This is resulting in KeyError exception during data parse. Once I replaced it my subscription view is working fine and all games are showing up correctly.

Phlaxith commented 3 years ago

Thank you @Oxenoth, I edited the file and it finally works! I had to disconnect and reconnect from the integration though

nodeunit commented 3 years ago

This fix works! Though the expanded options for disabling/enabling choice and trove aren't there still

UncleGoogle commented 3 years ago

Good spot @Oxenoth

I've just published another pre-release here: https://github.com/UncleGoogle/galaxy-integration-humblebundle/releases/tag/v0.9.2b

Could you please check if it works before I do global release? Unfortunately I'm no longer subscriber to test it myself.

Phlaxith commented 3 years ago

Hello @UncleGoogle

I just took the last archive and I assume it is now working 👍 But like @nodeunit said, the options for disabling/enabling choice months and trove still missing :

UncleGoogle commented 3 years ago

@Phlaxith so something does not work as expected :( Please share your logs

go to logs location:
- (Windows) %programdata%\GOG.com\Galaxy\logs
- (macOS) /Users/Shared/GOG.com/Galaxy/Logs
archive those logs to zip file
- plugin-humble-f0ca3d80-a432-4d35-a9e3-60f27161ac3a.log.txt
- plugin-humble-f0ca3d80-a432-4d35-a9e3-60f27161ac3a.log.1
- GalaxyClient.log
upload zip here

Phlaxith commented 3 years ago

Yes unfortunately every feature is not present :/ Didn't see any error log in the plugin_humble logs but here you are @UncleGoogle

[issue139]_logs.zip

UncleGoogle commented 3 years ago

@Phlaxith everything looks ok in logs. Even in GalaxyClient.log there is:

2020-12-09 12:06:25.575 [Information][ (0)] [TID 17796][galaxy_client]: Imported 14 subscriptions from platform 'humble': (name: 'Humble Choice 2020-11', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-10', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-09', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-08', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-07', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-06', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-05', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-04', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-03', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-02', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-01', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2019-12', is owned: true, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Choice 2020-12', is owned: false, end time: <NULL>, subscription_discovery: Automatic|UserEnabled), (name: 'Humble Trove', is owned: false, end time: <NULL>, subscription_discovery: Automatic|UserEnabled)
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-11': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-10': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-09': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-08': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-07': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-06': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-05': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-04': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-03': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-02': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-01': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2019-12': should import games=true, visibility setting=automatic, is owned=true.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Choice 2020-12': should import games=false, visibility setting=automatic, is owned=false.
2020-12-09 12:06:25.769 [Information][ (0)] [TID 17796][galaxy_client]: Subscription 'Humble Trove': should import games=false, visibility setting=automatic, is owned=false.

No idea what went wrong, looks like Galaxy bug. Anyways: thank you for testing it, I'm putting this on release branch.

Phlaxith commented 3 years ago

My pleasure, feel free to mention me if you need some help to test ! :)

UncleGoogle / galaxy-integration-humblebundle

Subscriptions still not shown (help needed from Basic or Premium subscriber!) #139

How you can help if you're Basic or Premium or Lite subscriber: