Allow properties to use environment variables

UndefinedOffset / silverstripe-nocaptcha

A spam protector and form field using Google's reCAPTCHA v2 or optionally a foundation v3 implementation

BSD 3-Clause "New" or "Revised" License

31 stars 37 forks source link

Allow properties to use environment variables #48

Closed scott1702 closed 5 years ago

scott1702 commented 5 years ago

Resolves https://github.com/UndefinedOffset/silverstripe-nocaptcha/issues/46 Site/secret keys would be a lot more secure as .env variables rather than stored in the codebase with yml. This also adds the ability to use env vars for proxy configuration as this is common in CWP.

Allow properties to use environment variables
Add logging and proxy port for validation curl request

Have made these changes backwards compatible to ensure no breakages to existing implementations.

UndefinedOffset commented 5 years ago

thanks

scott1702 commented 5 years ago

Thanks for the quick merge @UndefinedOffset! Would you please be able to give the module a tag with this change in place?

UndefinedOffset commented 5 years ago

tagged :)