search

UnderminersTeam / UndertaleModTool

The most complete tool for modding, decompiling and unpacking Undertale (and other GameMaker games!)
GNU General Public License v3.0
1.19k stars 233 forks source link

Fix UTMT crash when searching for a lot of unreferenced assets #1942

Closed maxiterr1 closed 1 month ago

maxiterr1 commented 1 month ago

For example, in Undertale, if you tried to find unreferenced assets in all groups UTMT would crash. This fixes that by using just a try catch.

Description

Old error: old error

Caveats

Notes

zivmaor commented 1 month ago

I couldn't reproduce the bug on the latest commit. This might have been fixed by PR #1923. Please check if you can reproduce the bug on the latest commit (caf0412)

maxiterr1 commented 1 month ago

Yes, I encountered the bug on the latest commit (caf0412). Later I'll comment attaching a video recreating the bug.

maxiterr1 commented 1 month ago

Before: https://github.com/user-attachments/assets/ea49f7c2-2a85-44fd-b8a7-b6fe270f67a6

After: https://github.com/user-attachments/assets/66784627-43aa-4653-9c1c-676e143f9717

There's a problem with my code that I noticed just now: It doesn't find unused strings.

zivmaor commented 1 month ago

I checked with Undertale version 1.08 and that's why I couldn't reproduce the bug. Rechecked with 1.001 and the bug happened. When I have time I'll look into it and try to find a more permanent solution.

zivmaor commented 1 month ago

I created a more permanent fix for this in PR #1947. Thank you for finding this bug.

maxiterr1 commented 1 month ago

Thank you for fixing it!

colinator27 commented 1 month ago

Closing, as this is superseded by https://github.com/UnderminersTeam/UndertaleModTool/pull/1947