search

Undev / redmine_close_button

Redmine Close Issue button plugin
https://github.com/Undev/redmine_close_button
Apache License 2.0
58 stars 30 forks source link

Support for subtasks #16

Open akzhan opened 13 years ago

akzhan commented 13 years ago

Just cite @thancock:

I was wondering whether you could make an improvement to fix a potential bug and make it even more user-friendly?

An important improvement is the behaviour of the close button when an issue features sub tasks, as there seems to be a minor bug with the current version. When I have closed all the sub tasks, clicking 'your' close button does not update the status of the button i.e. the close icon remains. I expect the button to behave in the same way when one closes a single ticket i.e. the close button is removed. Instead I must actually enter the issues and then update the issue by saving it (as status will have already been set to closed) or I have to refresh the page.

It would be really helpful (albeit not a higher priority as the aforementioned issue) if the following was supported: enable multiple sub tasks to be closed by pressing the close button once e.g. a. If sub tasks open >= 1 and the user presses the close button, the user should be warned (via dialog window) that they are about to close all sub tasks.

b. The user can choose from one of two options: OK or Cancel. Clicking 'OK' closes all the sub issues and the current issue clicking 'Cancel' returns the user to their previous state pre dialog window

akzhan commented 13 years ago

@thancock, by the way, @stepashka informs me that child tasks can be closed massively using context menu on subtasks list in parent task window.

thancock commented 13 years ago

Can you give me an example of such a workflow please, so I can test it?

On 07/11/2011 16:53, "Akzhan Abdulin" reply@reply.github.com wrote:

@thancock, by the way, @stepashka informs me that child tasks can be closed massively using context menu on subtasks list in parent task window.

akzhan commented 13 years ago
  1. Select wanted subtasks holding Shift button.
  2. Open context menu by right mouse click.
akzhan commented 13 years ago

Take a look at https://plus.google.com/u/0/photos/116024724616675174174/albums/5672304473343218065/5672304471867605090

thancock commented 13 years ago

Unfortunately, even with the screenshot it doesn't help me understand this :(

On 07/11/2011 17:07, "Akzhan Abdulin" reply@reply.github.com wrote:

  1. Select wanted subtasks holding Shift button.
  2. Open context menu by right mouse click.

Reply to this email directly or view it on GitHub: https://github.com/Undev/redmine_close_button/issues/16#issuecomment-26562 06

akzhan commented 13 years ago

Is your Redmine has context menus on task lists? It depends on your Redmine version. Context menus were intruduced by Redmine 1.0.

thancock commented 13 years ago

Yes it sure does.

I have:

A Main 1Issue - Cross Browser Testing

Within that Parent Task I have about 30 child tasks. Types vary; defect, change, requirement etc. Some subtasks are complete some aren't.

I can see the context menu by hovering over the title, and pressing the right mouse button.

I can change the status of one ticket to closed by selecting status > closed.

But it's not clear how I would change the status of more than one ticket to closed (say either all of the tickets in the issue or a selection of tickets).

Thanks for your help!

On 07/11/2011 17:45, "Akzhan Abdulin" reply@reply.github.com wrote:

Is your Redmine has context menus on task lists? It depends on your Redmine version.

Reply to this email directly or view it on GitHub: https://github.com/Undev/redmine_close_button/issues/16#issuecomment-26567 35

akzhan commented 13 years ago

You can select more than one ticket holding Shift key and choose tickets by clicking on 'em with left mouse button.

akzhan commented 13 years ago

Holding of Ctrl key also works, but in another way.

thancock commented 13 years ago

Thanks so much for your feedback, I'll take a look at this later today

On 08/11/2011 11:08, "Akzhan Abdulin" reply@reply.github.com wrote:

Holding of Ctrl key also works, but in another way.

Reply to this email directly or view it on GitHub: https://github.com/Undev/redmine_close_button/issues/16#issuecomment-26662 68

thancock commented 13 years ago

Hello again,

Finally got around to testing this.

I am using a mac and this is what I found:

Shift key: selects multiple tickets (be in blocks e.g. 1, 2, 3 you can be selected e.g. 1 and 3) Crtl key: does nothing (simply selects a single row as if you weren't pressing the key) Alt key: does nothing (simply selects a single row as if you weren't pressing the key) Cmd key: does nothing (simply selects a single row as if you weren't pressing the key)

On 08/11/2011 11:08, "Akzhan Abdulin" reply@reply.github.com wrote:

Holding of Ctrl key also works, but in another way.

Reply to this email directly or view it on GitHub: https://github.com/Undev/redmine_close_button/issues/16#issuecomment-26662 68

akzhan commented 13 years ago

Glad to hear this. I suppose that You should create a ticket for Redmine intself to correctly handle other key modifiers (and yes, there is Shift only handled correctly). May be will patched by somebody like me :)

thancock commented 13 years ago

That's a good point. I might just do that. I look forward to your software being updated in the future too :)

On 11/11/2011 12:19, "Akzhan Abdulin" reply@reply.github.com wrote:

Glad to hear this. I suppose that You should create a ticket for Redmine intself to correctly handle other key modifiers (and yes, there is Shift only handled correctly). May be will patched by somebody like me :)

Reply to this email directly or view it on GitHub: https://github.com/Undev/redmine_close_button/issues/16#issuecomment-27075 37