search

UniSharp / laravel-filemanager

Media gallery with CKEditor, TinyMCE and Summernote support. Built on Laravel file system.
https://unisharp.github.io/laravel-filemanager/
MIT License
2.09k stars 720 forks source link

add s3 support #1197

Open slimani-dev opened 1 year ago

slimani-dev commented 1 year ago

(optional) Issue number:

Summary of the change:

I have changed the image URL to use temporary URLs if the selected storage is s3

jonnott commented 3 months ago

@streamtw This would be amazing to have merged, so private S3 buckets can be used..

streamtw commented 2 months ago

Thanks for the info and this PR. I don't have a S3 bucket now. But I will sure apply one and test this PR before merging. Cannot garuantee a specific date though.

jonnott commented 2 months ago

Thanks for the info and this PR. I don't have a S3 bucket now. But I will sure apply one and test this PR before merging. Cannot garuantee a specific date though.

Thanks.

Seems the temporaryUrl() thing is needed for private S3 buckets. Also, we've been unable to make the thumbnails load from S3 buckets.

Might be worth looking at other PRs and issues around S3 at the same time, as it'd be good to get S3 compatibility fully fixed.

We are currently facing having to try and move away from this package because we have a large multi-tenant multi-server app which needs to use per-tenant S3 buckets for all stored files.

jonnott commented 1 month ago

Thanks for the info and this PR. I don't have a S3 bucket now. But I will sure apply one and test this PR before merging. Cannot garuantee a specific date though.

@streamtw Did you get anywhere with this?