search

UnifiedPush / android-connector

Mirror of https://codeberg.org/UnifiedPush/android-connector/
Apache License 2.0
35 stars 8 forks source link

fix: Use androidx.appcompat for better AlertDialog styling #93

Open nikclayton opened 3 months ago

nikclayton commented 3 months ago

Bumps minSdk to 21.

p1gp1g commented 3 months ago

I think this is preferable to not update the minSdk

nikclayton commented 3 months ago

Would you consider splitting this in to android-connector and android-connector-ui libraries, with the "...WithDialog" related functionality moving to the -ui library?

Looking at the first and third screenshot in https://github.com/UnifiedPush/android-connector/issues/87, the difference in visuals is pretty jarring, especially when this dialog might be one of the first bits of UI they see from an app that uses this library (assuming that apps try and register early in the startup process).

p1gp1g commented 3 months ago

You mean publishing a new library ?

The purpose of this dialog is to provide a quick and dirty way to use the lib, but most app write their own way to pick a distributor. So I don't think it is worth losing 5 SDK versions

nikclayton commented 3 months ago

You mean publishing a new library ?

Yes. The -ui library would have minSdk set to 21 to allow the use of androidx.appcompat, the existing library would stay at 16.

The purpose of this dialog is to provide a quick and dirty way to use the lib, but most app write their own way to pick a distributor. So I don't think it is worth losing 5 SDK versions

https://github.com/search?q=UnifiedPush+registerAppWithDialog&type=code has some false positives, but I'm not sure it supports the idea that "most apps write their own way".