Uniswap / v4-periphery

🦄 🦄 🦄 🦄 Peripheral smart contracts for interacting with Uniswap v4

https://blog.uniswap.org/uniswap-v4

MIT License

716 stars 495 forks source link

OZ-L07: Unsubscribe on Burn (+ remove arbitrary data) #314

Closed saucepoint closed 2 months ago

saucepoint commented 3 months ago

Related Issue

OZ-L07: burning a position should unsubscribe a position

Description of changes

When burning a position, if it has a subscriber, automatically unsubscribe.

Big Change:

Removed bytes memory data from unsubscribe()

Passing additional data to burn adds gas overhead for obscure cases
Users can forcibly provide invalid data and still be able to unsubscribe. I.e. There was never really an enforcement that data was valid