United-Philanthropy-Forum / km-starter-kit

KM Starter Kit
0 stars 1 forks source link

static tests fail after new site spinup, because web/themes/custom and web/modules/custom directories do not exist #35

Closed aaronbauman closed 1 year ago

aaronbauman commented 1 year ago

The composer lint job (triggered by .ci/test/static/run) fails because it's trying to run on directories that don't exist.

e.g. https://app.circleci.com/pipelines/github/United-Philanthropy-Forum/messageagency-km-test4/1/workflows/654f8b38-b3c8-432c-80cc-105353df7dd2/jobs/3

Screenshot 2023-02-20 at 10 17 18 AM

Adding the directories with .gitkeeps to this repo would fix it, but maybe there's a reason it hasn't been done?

unclegcb commented 1 year ago

Naw, it's because we haven't really spun up that many sites and we just create those directories early in the process. I suspect a .gitkeep would be a great time/confusion saver here.

aaronbauman commented 1 year ago

https://github.com/United-Philanthropy-Forum/km-starter-kit/pull/36 merged. Closing.