United4Surveillance / signal-detection-tool

A tool for detection of signals in infectious disease surveillance data.
Other
8 stars 0 forks source link

[BUG] use of conjure_filename() is unclear and example does not work #148

Open alchalu opened 7 months ago

alchalu commented 7 months ago

Describe the Bug Example for conjure_filename() does not work since the signal data does not have the relevant columns

To Reproduce

data <- preprocess_data(input_example)
conjure_filename(get_signals(data))

Expected Behavior return string of the following form signals_method_country_pathogen_startdate_enddate.csv

Additional Context Function is not used. Do we even need this functio?

Add any other context about the problem here.

alchalu commented 7 months ago

same applies to save_signals()

jaemol commented 7 months ago

Function is not used. Do we even need this functio?

same applies to save_signals()

Maybe these will be relevant in relation to #157?