dunity
commented
5 years ago @mtschoen-unity All draw order issues should be resolved in ToolsMenu and RadialMenu button materials.
Closed dunity closed 5 years ago
dunity
commented
5 years ago @mtschoen-unity All draw order issues should be resolved in ToolsMenu and RadialMenu button materials.
dunity
commented
5 years ago Latest Development was also merged in
mtschoen-unity
commented
5 years ago Looks good!
Purpose of this PR
*1: Fix ToolsMenuButton ray intersection bugs. Refactor existing primary & secondary ToolsMenuButton colliders to use custom mesh colliders.
*2: Fix various stencil issues in the ToolsMenu, RadialMenu, and Filter/FocusUI. The main visual issue that was addressed was the ToolsMenu and radial menu buttons all drew "through" each other; due to their all sharing the same (incorrect & not dynamically assigned) stencil ID. This led to finding that the ToolsMenu and RadialMenu didn't implement proper stencil ID handling; so ended up adding that implementation for both menus.
Testing status
I've tested thoroughly in 2018.1 & 2018.2, and didn't see any related bugs or issues arise. I saw no new/unknown visual issues when testing amidst the MainMenu, and various workspaces.
Technical risk
Low. Aside from the dynamic stencil arch added to the ToolsMenu & RadialMenu, much of these changes are cosmetic, and have been tested amidst the other menus, and the workspaces.
Comments to reviewers
The main points of focus are the ToolsMenu, and the RadialMenu buttons, how it is they are drawn amidst the other UI elements (main menu, and workspaces mostly). Side note, the field/member arrangement in the RadialMenuSlot class was hard to look at, so I cleaned up the order/layout a bit. Please pardon this making the diff on that class a bit busier than it probably needed to me.