Unity-Technologies / GooglePlayLicenseVerification

Unity Android plugin example on how to interface the Google Play License Verification (LVL) servers
MIT License
84 stars 26 forks source link

Unclear relationship between numerical response code received and its expected meaning #12

Open brantkings opened 4 years ago

brantkings commented 4 years ago

Hello! The response code you get here is numerical, while Google on its documentation is dealing with string response codes (probably because native LVL already does the conversion in the background, and doesn't mention the numerical ones anywhere). You would want to know what the codes mean if you want to implement behaviour for all the possible responses. Can you update the readme about this? Or maybe I didn't see it?

The conversion of Response codes should be:

private static final int LICENSED = 0x0;
private static final int NOT_LICENSED = 0x1;
private static final int LICENSED_OLD_KEY = 0x2;
private static final int ERROR_NOT_MARKET_MANAGED = 0x3;
private static final int ERROR_SERVER_FAILURE = 0x4;
private static final int ERROR_OVER_QUOTA = 0x5;
private static final int ERROR_CONTACTING_SERVER = 0x101;
private static final int ERROR_INVALID_PACKAGE_NAME = 0x102;
private static final int ERROR_NON_MATCHING_UID = 0x103;

I found out about this digging in the closes Issues and seeing a response of someone about this: https://github.com/Unity-Technologies/GooglePlayLicenseVerification/issues/3#issuecomment-474763345

This was pretty annoying as Google themselves is using this project as instruction to developers to implement LVL on Unity.

Thanks!

ghost commented 4 years ago

Thanks for reporting. I'll be looking into this, but some delay should be expected.