search

UnityTechnologies / open-project-1

Unity Open Project #1: Chop Chop
http://unity.com/open-projects
Apache License 2.0
5.75k stars 2.03k forks source link

Fixed Scene Reloading issue in SceneLoader.cs #487

Closed HarshNarayanJha closed 3 years ago

HarshNarayanJha commented 3 years ago

Is this PR linked to an issue? If so please link it here, if not please create one first, then link it.
Yes, it is: https://github.com/UnityTechnologies/open-project-1/issues/486

Is there a forum thread linked to this issue? If so please link it here.
Yes, it is too: https://forum.unity.com/threads/reloading-scene-using-addressables.1149521/#post-7377545

How did you resolve this issue?
Just by returning from the LoadLocation function if currentScene == LocationToLoad;

How can it be verified that the issue has actually been resolved?
Maybe using this: https://forum.unity.com/threads/debug-system.1151783/ I also verified that this issue is reproduced and also that it is fixed using this. Or the user stroibot on unity forums. He made me aware of that bug.

Thanks.

ciro-unity commented 3 years ago

I misunderstood the PR in the first place. This is trying to "fix" an issue we don't have, and doing so with a simple silent failure (I know it gives the Debug.Log, but still, useless in the final build). So I'll be closing it.