search

UniversalRobots / Universal_Robots_ROS2_Description

ROS2 URDF description for Universal Robots
BSD 3-Clause "New" or "Revised" License
100 stars 95 forks source link

Migrate from package + relative paths in launchfiles to absolute paths #159

Closed fmauch closed 2 months ago

fmauch commented 2 months ago

That makes launchfiles much more reusable

gavanderhoorn commented 2 months ago

Could you give an example of the change proposed in the issue title?

fmauch commented 2 months ago

@gavanderhoorn #160 would be the changes required for this repo. Basically, to re-use the view_robot launchfile in other packages one had to create another package containing the custom description and an rviz configuration. With the proposed changes one only needs to provide the custom description and can re-use the rviz configuration if one likes. In the context of the description package this not that relevant, but we are performing that change in all UR packages at the moment.

As any feedback is always welcome: Do you have any thoughts on this approach?