search

UnlawfulCitizen / nmodbus

Automatically exported from code.google.com/p/nmodbus
0 stars 0 forks source link

Proposed for FtdAdapter #43

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I would like to propose a patch to the FtdAdapter (see attached). Add a
ReadLine method to read up to the newline character in the input buffer
similar to the other transports (Serial, TCP etc). We have to add these
changes into each new FtdAdapter version but they may be beneficial to the
project.

Original issue reported on code.google.com by n.cu...@kelman.co.uk on 26 Mar 2009 at 8:06

Attachments:

GoogleCodeExporter commented 9 years ago 
Why do you need the ReadLine method? Are you using FtdAdapter directly? I used 
to 
have the ReadLine method (Revision 237) but removed it as it's not needed by 
the 
IStreamResource.

Original comment by sja...@gmail.com on 27 Mar 2009 at 4:54

GoogleCodeExporter commented 9 years ago 
Please accept my apologies. I manage a team of remote software developers. They 
kept
adding this ReadLine method and I assumed it was required and so did not 
question it.
After reviewing the code, it seems that we do not actually use the ReadLine 
method. I
will ask that this method be removed from our repository.

You can ignore the ReadLine method in the proposed patch. 

I understand that the casting for the timeouts is now fixed in your trunk.

Original comment by n.cu...@kelman.co.uk on 30 Mar 2009 at 2:41

GoogleCodeExporter commented 9 years ago

Original comment by sja...@gmail.com on 2 Apr 2009 at 6:06