search

Unleash / unleash

Open-source feature management solution built for developers.
https://getunleash.io
Apache License 2.0
11.45k stars 721 forks source link

chore: use memoized stats for version #8776

Closed gastonfournier closed 5 days ago

gastonfournier commented 1 week ago

About the changes

Builds on top of #8766 to use memoized results from stats-service. Because stats service depends on version service, and to avoid making the version service depend on stats service creating a cyclic dependency. I've introduced a telemetry data provider. It's not clean code, but it does the job.

After validating this works as expected I'll clean up

Added an e2e test validating that the replacement is correct: 8475492 and it did: https://github.com/Unleash/unleash/actions/runs/11861854341/job/33060032638?pr=8776#step:9:294

Finally, cleaning up version service

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **unleash-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/unleash-team/unleash-docs/4d4YF5Js72sYDRbFn36ZWMjSeKot)) | [Visit Preview](https://unleash-docs-git-use-memoized-stats-unleash-team.vercel.app) | | Nov 18, 2024 9:12am | | **unleash-monorepo-frontend** | ⬜️ Ignored ([Inspect](https://vercel.com/unleash-team/unleash-monorepo-frontend/B6ktmjocnLfZr5b8SW7iTK8Hx8cr)) | [Visit Preview](https://unleash-monorepo-frontend-git-use-memoized-stats-unleash-team.vercel.app) | | Nov 18, 2024 9:12am |
github-actions[bot] commented 1 week ago

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files