(MINOR) Refactoring application to use @apollo/client 3.x (from #291)

UnlyEd / next-right-now

Flexible production-grade boilerplate with Next.js 11, Vercel and TypeScript. Includes multiple opt-in presets using Storybook, Airtable, GraphQL, Analytics, CSS-in-JS, Monitoring, End-to-end testing, Internationalization, CI/CD and SaaS B2B multi single-tenancy (monorepo) support

https://unlyed.github.io/next-right-now/

MIT License

1.27k stars 110 forks source link

(MINOR) Refactoring application to use @apollo/client 3.x (from #291) #294

Closed Vadorequest closed 3 years ago

Vadorequest commented 3 years ago

Refactoring application to use @apollo/client 3.x
Use lodash.isequal instead of lodash/isEqual
Reformating (bulk)
Fix isActive for "catch all routes" page
Rename prop name to __APOLLO_STATE__
Reformating

Co-authored-by: Dhenain Ambroise ambroise.dhenain@gmail.com

github-actions[bot] commented 3 years ago

:white_check_mark: Deployment SUCCESS Commit bf588275d94b6b0f162224f6a9affcc840712ac5 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-nkklmsemq-unly-oss.vercel.app Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-c1-with-apol.vercel.app

github-actions[bot] commented 3 years ago

:white_check_mark: Deployment SUCCESS Commit bf588275d94b6b0f162224f6a9affcc840712ac5 successfully deployed Storybook static site to https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-fu7xzbn7f-unly-oss.vercel.app Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-storybook

github-actions[bot] commented 3 years ago

:white_check_mark: E2E tests SUCCESS for commit bf588275d94b6b0f162224f6a9affcc840712ac5 previously deployed Storybook static site at https://nrn-v2-mst-aptd-gcms-lcz-sty-storybook-fu7xzbn7f-unly-oss.vercel.app

github-actions[bot] commented 3 years ago

:white_check_mark: E2E tests SUCCESS for commit bf588275d94b6b0f162224f6a9affcc840712ac5 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-nkklmsemq-unly-oss.vercel.app

Vadorequest commented 3 years ago

@samuelcastro Everything looks good, awaiting your validation regarding the changes I did in #291 to merge this. Good work! 💪

samuelcastro commented 3 years ago

@samuelcastro Everything looks good, awaiting your validation regarding the changes I did in #291 to merge this. Good work! 💪

Overall looks good to me @Vadorequest. Just a small feedback around __APOLLO_STATE__

samuelcastro commented 3 years ago

@Vadorequest https://github.com/UnlyEd/next-right-now/pull/295

Vadorequest commented 3 years ago

Thanks for catching those, I'll update your PR to use the actual variable/constant instead of an unnamed constant so this doesn't happen ever again. 😉

github-actions[bot] commented 3 years ago

:x: Deployment FAILED Commit 0ff6dc89f2ee21b32de33553a01e1be44f71ea69 failed to deploy to []() click to see logs

github-actions[bot] commented 3 years ago

:white_check_mark: Deployment SUCCESS Commit 1258a15e82a997fe506c501d35f0e2a9e8a7bb18 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-bp48zo3pj-unly-oss.vercel.app Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-c1-with-apol.vercel.app

github-actions[bot] commented 3 years ago

:white_check_mark: E2E tests SUCCESS for commit 1258a15e82a997fe506c501d35f0e2a9e8a7bb18 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-bp48zo3pj-unly-oss.vercel.app