Unmanic / unmanic

Unmanic - Library Optimiser
GNU General Public License v3.0
1.66k stars 82 forks source link

executables from python packages in plugin requirements not found in path #413

Open bregell opened 1 year ago

bregell commented 1 year ago

Description

Executables from python packages in plugin requirements not found in path.

Steps to Reproduce

  1. Example: add ffmpeg-normalize to plugin requirements.txt
  2. Add command "ffmpeg-normalize --version" to data['exec_command]
  3. Package and install plugin
  4. Add plugin to library and make it start process
  5. Plugin execution will fail because ffmpeg-normalize cannot be found on system path

Expected behaviour: [What you expect to happen]

I expect that each plugin has the site-packages/bin added to path so that the plugin can utilise the executables from the packages installed from requirements.txt

Actual behaviour: [What actually happens]

The path is not added and thus the execution of the plugin fails.

Reproduces how often: [What percentage of the time does it reproduce?]

100%

Versions

0.2.4~7339f8b

Installation Method Used

Tested on Bare metal and Docker.