Unrud / video-downloader

Download videos from websites like YouTube and many others (based on yt-dlp)
GNU General Public License v3.0
767 stars 96 forks source link

ERROR: setfattr: invalid option -- 'o' #126

Open verysharpknife opened 2 years ago

verysharpknife commented 2 years ago

Hello, sometimes downloads fail when trying to pull mp3 from YouTube. For example when I try to download this "https://www.youtube.com/watch?v=-oZGkvXKckE" or "https://www.youtube.com/watch?v=-N4jf6rtyuw" as an audio I get the following errors.

ERROR: setfattr: invalid option -- 'o' Usage: setfattr {-n name} [-v value] [-h] file... setfattr {-x name} [-h] file... Try `setfattr --help' for more information.

ERROR: setfattr: invalid option -- 'N' Usage: setfattr {-n name} [-v value] [-h] file... setfattr {-x name} [-h] file... Try `setfattr --help' for more information.

I think it's because of the "-" symbol in the URLs. Also this error stops downloading my entire playlist, not cool. I hope this can be fixed, because I kinda love this application.

Unrud commented 2 years ago

I can't reproduce the issue with the Flatpak or Snap version. Can you provide a debug log? https://github.com/Unrud/video-downloader#debug

Edit: My best guess is that it's caused by an older version of setfattr, not accepting a value starting with -.

verysharpknife commented 2 years ago

My attr version is attr-2.5.1-3.fc35.x86_64

yt-dlp debug log:

(video-downloader:37798): yt-dlp-DEBUG: 22:46:02.561: [youtube:tab] Downloading playlist WL; add --no-playlist to just download video -N4jf6rtyuw
(video-downloader:37798): yt-dlp-DEBUG: 22:46:02.561: [youtube:tab] WL: Downloading webpage
(video-downloader:37798): yt-dlp-DEBUG: 22:46:03.184: [youtube:tab] Unable to recognize playlist. Downloading just video -N4jf6rtyuw
(video-downloader:37798): yt-dlp-DEBUG: 22:46:03.201: [youtube] -N4jf6rtyuw: Downloading webpage
(video-downloader:37798): yt-dlp-DEBUG: 22:46:03.806: [youtube] -N4jf6rtyuw: Downloading android player API JSON
(video-downloader:37798): yt-dlp-DEBUG: 22:46:04.172: [info] -N4jf6rtyuw: Downloading 1 format(s): 251
(video-downloader:37798): yt-dlp-DEBUG: 22:46:04.176: [info] Writing video metadata as JSON to: 00001.info.json
(video-downloader:37798): yt-dlp-DEBUG: 22:46:04.850: [info] -N4jf6rtyuw: Downloading 1 format(s): 251
(video-downloader:37798): yt-dlp-DEBUG: 22:46:04.855: Deleting existing file -N4jf6rtyuw.251.webp
(video-downloader:37798): yt-dlp-DEBUG: 22:46:04.855: [info] Downloading video thumbnail 41 ...
(video-downloader:37798): yt-dlp-DEBUG: 22:46:05.051: [info] Writing video thumbnail 41 to: -N4jf6rtyuw.251.webp
(video-downloader:37798): yt-dlp-DEBUG: 22:46:05.095: [yt_dlp_slave] Converting thumbnail
(video-downloader:37798): yt-dlp-DEBUG: 22:46:05.186: [download] -N4jf6rtyuw.251.webm has already been downloaded
(video-downloader:37798): yt-dlp-DEBUG: 22:46:05.187: [download] 100% of 2.83MiB
(video-downloader:37798): yt-dlp-DEBUG: 22:46:05.268: [ExtractAudio] Destination: -N4jf6rtyuw.251.mp3
(video-downloader:37798): yt-dlp-DEBUG: 22:46:08.370: [EmbedThumbnail] ffmpeg: Adding thumbnail to "-N4jf6rtyuw.251.mp3"
(video-downloader:37798): yt-dlp-DEBUG: 22:46:08.474: [Metadata] Adding metadata to "-N4jf6rtyuw.251.mp3"
(video-downloader:37798): yt-dlp-DEBUG: 22:46:08.582: [EmbedSubtitle] Subtitles can only be embedded in mp4, webm or mkv files
(video-downloader:37798): yt-dlp-DEBUG: 22:46:08.583: [XAttrMetadata] Writing metadata to file's xattrs
(video-downloader:37798): yt-dlp-DEBUG: 22:46:08.583: ERROR: setfattr: invalid option -- 'N'
(video-downloader:37798): yt-dlp-DEBUG: 22:46:08.583: Usage: setfattr {-n name} [-v value] [-h] file...
(video-downloader:37798): yt-dlp-DEBUG: 22:46:08.583:        setfattr {-x name} [-h] file...
(video-downloader:37798): yt-dlp-DEBUG: 22:46:08.583: Try `setfattr --help' for more information.