search

UnstoppableSwap / core

Bitcoin–Monero Cross-chain Atomic Swap (+ GUI)
GNU General Public License v3.0
22 stars 6 forks source link

upgrade(swap): Upgrade bdk library #180

Open Einliterflasche opened 6 days ago

Einliterflasche commented 6 days ago

This closes #98.

Einliterflasche commented 6 days ago

Oh boy. It looks like we'll have to upgrade bitcoin as well, since bdk_wallet@1.0.0 uses bitcoin@0.32 but we use bitcoin@0.29. I did that and instantly received ~500 compile errors. This upgrade is not at all trivial.

binarybaron commented 6 days ago

Oh boy. It looks like we'll have to upgrade bitcoin as well, since bdk_wallet@1.0.0 uses bitcoin@0.32 but we use bitcoin@0.29. I did that and instantly received ~500 compile errors. This upgrade is not at all trivial.

That's a bummer but I'd assume it's mostly a few API changes that propogate through the codebase. The Bitcoin protocol hasn't changed.

Einliterflasche commented 5 days ago

Probably. The changelog isn't very clear on that, sadly.

binarybaron commented 5 days ago

We also have to consider that this upgrade could be a breaking network upgrade if the serde serialization structures have changed.

binarybaron commented 9 hours ago

I haven't looked too much what you are doing here but fyi you do not really need to do any backwards compatability stuff. Our descriptor is derived from our seed.pem which does not change, and we can just re-scan our wallet at first startup.

Einliterflasche commented 8 hours ago

The docs recommended that we get the revelation indices of the wallet to speed up the migration, so that's why I kept some of the old wallet code around