UoA-CARES / cares_reinforcement_learning

CARES Reinforcement Learning Package
11 stars 2 forks source link

Dev/record #59 #60

Closed long715 closed 1 year ago

long715 commented 1 year ago

Implementation of Record class in _example_trainingloops.py

Changes made to Plot.py:

To work on:

long715 commented 1 year ago

Everything is looking good! Added my own commits to fix a bug in the Record class. Currently coming across a bug that creates multiple blank windows – specifically for the TD3 or policy example. Are you experiencing the same?

Screenshot 2023-06-13 at 4 27 06 PM

Yep, Im getting this bug as well. Seems to happen after 1200 steps, next episode log after the logs of actor/critic losses. I found a quick fix by commenting out the plot.post() command at line 118 for policy example. Tested it with another max_steps_exploration value and same thing happens where the figures appear after the actor/critic writes. Not sure why this is happening, the plot instance data should be independent of whats in the record file :'

retinfai commented 1 year ago

True. It's probably something to do with matplotlib being trash. I reckon we remove that for now, and bundle this problem into the new issue #63 and we can merge the current integration you've done. Thoughts?

long715 commented 1 year ago

True. It's probably something to do with matplotlib being trash. I reckon we remove that for now, and bundle this problem into the new issue #63 and we can merge the current integration you've done. Thoughts?

Sounds good! I'll quickly fix it up now 🙏