search

UofTCoders / rcourse

Reproducible Quantitative Methods for EEB
https://uoftcoders.github.io/rcourse/
Other
21 stars 33 forks source link

Lec06 #313

Closed smile4life closed 4 years ago

smile4life commented 4 years ago

I think I fixed this? Just trying to figure out what I messed up :P

smile4life commented 4 years ago

Dangit, meant to make the pull request to a new branch 🤦‍♀

smile4life commented 4 years ago

image I feel like I made a mistake when I rebased?

smile4life commented 4 years ago

OKAY. The "files changed" section does only show 4 files. My branch was up-to-date with UofTCoders:master when I made this request 😌

The rebasing I did for my branch removed the records of those interim commits, I think.

QuLogic commented 4 years ago

You rebased too many commits here, e.g., stuff authored by James and committed by you shouldn't be here, since those are redundant.

smile4life commented 4 years ago

I definitely agree that scatterplots are important to cover, but I'm pretty confident that I'll have time to cover it effectively. I think that most of the live-coding for the earlier sections (mostly just the histogram one?) will just involve making slight adjustments to the first plot: changing the bin widths and filtering the data source?

James-S-Santangelo commented 4 years ago

Looks great, thanks Zoë! Will leave it until the morning so that @aays and others have a chance to look through it (Ahmed is currently in a different time zone).