search

Upload / Up1

Client-side encrypted image host web server
MIT License
813 stars 97 forks source link

Shell scripts should be treated like text #44

Open expectocode opened 8 years ago

expectocode commented 8 years ago

I love my up1 instance and use it a fair bit, but i find that i can't share .sh files as easily as i'd like. This should be a simple fix, please implement.

andre-d commented 8 years ago

Ah your browser calls them "application/" I will add it to the exception list. On Jan 25, 2016 5:54 PM, "expectocode" notifications@github.com wrote:

I love my up1 instance and use it a fair bit, but i find that i can't share sh files as easily as i'd like This should be a simple fix, please implement

— Reply to this email directly or view it on GitHub https://github.com/Upload/Up1/issues/44.

expectocode commented 8 years ago

Ah, good good. I was trying to fix it with 

  'text/x-shellscript': 'text',
andre-d commented 8 years ago

Browsers are giving them a blank mime type, I recall seeing when I developed the logic originally that it ran a check for null bytes and called it text/plain if it had none but binary otherwise..but I am not seeing that....just an empty mime type in FF and Chrome..I will look into running that check myself for small files.