search

UrbanAnalyst / dodgr

Distances on Directed Graphs in R
https://urbananalyst.github.io/dodgr/
127 stars 16 forks source link

fix fundamental cycles #141

Open mpadge opened 4 years ago

mpadge commented 4 years ago

The current code does not return a minimal cycle basis at all. Maybe implement the same algorithm as networkx (with code here), which is described in this paper (direct pdf link here). Another possibility is described in this arXiv paper. Here is also Johnson's original 1975 paper, Finding all the elementary circuits of a directed graph.

mpadge commented 6 days ago

https://www.chiark.greenend.org.uk/~sgtatham/quasiblog/findloop/ - especially the last algorithm, Tarjan's Bridge-finding algorithm, looks sound.