search

UrbanApps / Armchair

A simple yet powerful App Review Manager for iOS and OSX in Swift
MIT License
1.2k stars 137 forks source link

Mac Version doesn't compile #117

Open Vithanco opened 6 years ago

Vithanco commented 6 years ago

I might overlook something, but the a8c1dfd version doesn't seem to compile on a Mac. UseStoreKitReviewPrompt seems to be missing. It is only declared for iOS. 

#if os(iOS)
    public func useStoreKitReviewPrompt() -> Bool {
...

but it is needed elsewhere, like in shouldTryStoreKitReviewPrompt, where it says function is available for all macOS versions. 

    public var shouldTryStoreKitReviewPrompt : Bool {
        if #available(iOS 10.3, *), useStoreKitReviewPrompt { return true }

Please review. Thanks for this great library.

Vithanco commented 6 years ago

I don't think this issue was introduced with a8c1dfd.

coneybeare commented 6 years ago

It was introduced on https://github.com/UrbanApps/Armchair/pull/112 by @MartinMoizard, but I haven't had time to revert it. Pulls welcome.