search

UrbanApps / Armchair

A simple yet powerful App Review Manager for iOS and OSX in Swift
MIT License
1.2k stars 137 forks source link

Using the store kit review prompt will ask for reviews forever if the user taps "Not Now" #93

Closed ari3l closed 7 years ago

ari3l commented 7 years ago

SKStoreReviewController doesn't have an API that tells us if the user submits a review, as a result, if rating conditions are met the library will constantly ask for a review.

I fixed this locally by setting UserDefaults to mark the current version as reviewed when calling requestReview(). This means that the user will see the review prompt once per version, regardless if the user rates or not.

I can submit a PR with the fix, but I'm not sure if that would be the correct approach. Let me know what you guys think!

coneybeare commented 7 years ago

I think your approach is reasonable. Thanks for catching that