search

UrbanApps / UAAppReviewManager

UAAppReviewManager is a simple and lightweight App review prompting tool for iOS and Mac App Store apps. It's Appirater all grown up, ready for primetime.
MIT License
801 stars 117 forks source link

Make UAAppReviewManager more inheritance friendly #13

Open tonyxiao opened 10 years ago

tonyxiao commented 10 years ago

Use [self class] rather than UAAppReviewManager explicitly.

Also maybe separate the class convenience methods into a separate file for those who want it and expose the actual instance methods for subclasses to override.

coneybeare commented 10 years ago

Good idea. Would you be willing to do the alterations to the class methods and submit a PR?

coneybeare commented 10 years ago

For clarification, I don't want to expose the instance methods, but they can be added manually in a private header of the subclass for those who want to subclass it. I do like the idea of using [self class] instead of UAAppReviewManager though.