Closed LeoNatan closed 11 years ago
Currently, there is a way to configure whether or not it will prompt on the current build version, but it is setup through combinations of the tracksNewVersions
and shouldPromptIfRated
properties, but I like the idea of having any logic be applied here. If you throw something together, I would be happy to take a look at it, otherwise I can probably look into adding this in a couple of weeks.
Check out the prompt-blocks branch and let me know if this meets your expectations on the feature.
Looks great, thanks!
A few comments: I see the blocks are called in a low priority queue. Consider adding to the documentation that the "shouldPrompt" blocks will be called on an arbitrary thread. This may prevent confusion of expecting the callback on the main thread and so on. A few minor spelling mistakes I noticed - "diaplay", capitalized "Similar", etc.
Great job, thank you!
Updated to run shouldPromptBlock
on main thread. Maybe you can help out by merging and testing. I am currently on a flight and my battery is just about dead, then am unavailable for about a week. If all is good, I will merge into master when I get back.
I will try. Thanks
Oops, sorry, didn't mean to close.
Currently, there is "setShouldPromptIfRated:" and in the comment, it is said to pass YES value for major versions and NO for minor versions.
I propose the following optional API:
typedef BOOL (^UAAppReviewManagerShouldPromptBlock) (NSString* previousVersion, NSString* currentVersion);
If this is set, before prompting, a call will be made to the user's passed block to determine whether the current build is minor or major (or any other logic).
Thanks, Leo