Properly allocate bytes in the bss

Uzebox / uzebox

A retro-minimalist game console engine for the ATMega644

http://uzebox.org

126 stars 43 forks source link

Closed flaviozavan closed 7 years ago

flaviozavan commented 7 years ago

Newer gcc versions (6.2.0) don't like the way bytes are allocated in the bss and will refuse to compile. See here: http://uzebox.org/forums/viewtopic.php?f=3&t=2371&p=18023#p18023

I replaced all .byte 1 occurrences in .bss by .space 1 .word 1 by .space 2 .long 1 by .space 4

All demos compile and I tested a mode 3 game with success. Another set of eyes to catch possible mistakes would be nice.

Jubatian commented 7 years ago

I scanned it through, it seems like it should work identically to the version before. I only noticed a damaged comment:

kernel/videoMode6/videoMode6.s , line 48 ("bytes" replaced to "spaces")

I would say pull for this, it is an important change to make the kernel working according to Gas's documentation.